add some horz and vert zoom actions; remove some whitespace from the code of the ui-actions, so they are easier to see and maintain

4 files changed, 101 insertions, 83 deletions

diff --git a/libs/surfaces/control_protocol/basic_ui.cc b/libs/surfaces/control_protocol/basic_ui.cc
index b57373f883..a1e499b93e 100644
--- a/libs/surfaces/control_protocol/basic_ui.cc
+++ b/libs/surfaces/control_protocol/basic_ui.cc
@@ -345,89 +345,44 @@ BasicUI::jump_by_bars (double bars)
 	session->request_locate ( session->convert_to_frames (any) );
 }
 
-void
-BasicUI::mark_in ()
-{
-	access_action("Editor/start-range");
-}
-
-void
-BasicUI::mark_out ()
-{
-	access_action("Editor/finish-range");
-}
-
-void
-BasicUI::toggle_click ()
-{
-	access_action("Transport/ToggleClick");
-}
-
-void
-BasicUI::midi_panic ()
-{
-	access_action("MIDI/panic");
-}
-
-void
-BasicUI::toggle_roll ()
-{
-	access_action("Transport/ToggleRoll");
-}
-
-void
-BasicUI::stop_forget ()
-{
-	access_action("Transport/ToggleRollForgetCapture");
-}
-
-void
-BasicUI::set_punch_range ()
-{
-	access_action("Editor/set-punch-from-edit-range");
-}
-
-void
-BasicUI::set_loop_range ()
-{
-	access_action("Editor/set-loop-from-edit-range");
-}
-
-void
-BasicUI::set_session_range ()
-{
-	access_action("Editor/set-session-from-edit-range");
-}
-
-void
-BasicUI::toggle_monitor_mute ()
-{
-	//access_action("Editor/toggle_monitor_mute");   ToDo
-}
-
-void
-BasicUI::toggle_monitor_dim ()
-{
-	//access_action("Editor/toggle_monitor_dim");    ToDo
-}
-
-void
-BasicUI::toggle_monitor_mono ()
-{
-	//access_action("Editor/toggle_monitor_mono");    ToDo
-}
-
-void
-BasicUI::quick_snapshot_stay ()
-{
-	access_action("Main/QuickSnapshotStay");
-}
-
-void
-BasicUI::quick_snapshot_switch ()
-{
-	access_action("Main/QuickSnapshotSwitch");
-}
+void BasicUI::mark_in () { access_action("Editor/start-range"); }
+void BasicUI::mark_out () { access_action("Editor/finish-range"); }
+
+void BasicUI::toggle_click () { access_action("Transport/ToggleClick"); }
+void BasicUI::midi_panic () { access_action("MIDI/panic"); }
+void BasicUI::toggle_roll () { access_action("Transport/ToggleRoll"); }
+void BasicUI::stop_forget () { access_action("Transport/ToggleRollForgetCapture"); }
+
+void BasicUI::set_punch_range () { access_action("Editor/set-punch-from-edit-range"); }
+void BasicUI::set_loop_range () { access_action("Editor/set-loop-from-edit-range"); }
+void BasicUI::set_session_range () { access_action("Editor/set-session-from-edit-range"); }
+
+void BasicUI::toggle_monitor_mute () { /*access_action("Editor/toggle_monitor_mute");  */ }
+void BasicUI::toggle_monitor_dim () {  /*access_action("Editor/toggle_monitor_dim");  */ }
+void BasicUI::toggle_monitor_mono () { /*access_action("Editor/toggle_monitor_mono");  */ }
+
+void BasicUI::quick_snapshot_stay () { access_action("Main/QuickSnapshotStay"); }
+void BasicUI::quick_snapshot_switch () { access_action("Main/QuickSnapshotSwitch"); }
+
+void BasicUI::fit_1_track() { access_action("Editor/fit_1_track"); }
+void BasicUI::fit_2_tracks() { access_action("Editor/fit_2_tracks"); }
+void BasicUI::fit_4_tracks() { access_action("Editor/fit_4_tracks"); }
+void BasicUI::fit_8_tracks() { access_action("Editor/fit_8_tracks"); }
+void BasicUI::fit_16_tracks() { access_action("Editor/fit_16_tracks"); }
+void BasicUI::fit_32_tracks() { access_action("Editor/fit_32_tracks"); }
+void BasicUI::fit_all_tracks() { access_action("Editor/fit_all_tracks"); }
+
+void BasicUI::zoom_10_ms() { access_action("Editor/zoom_10_ms"); }
+void BasicUI::zoom_100_ms() { access_action("Editor/zoom_100_ms"); }
+void BasicUI::zoom_1_sec() { access_action("Editor/zoom_1_sec"); }
+void BasicUI::zoom_10_sec() { access_action("Editor/zoom_10_sec"); }
+void BasicUI::zoom_1_min() { access_action("Editor/zoom_1_min"); }
+void BasicUI::zoom_5_min() { access_action("Editor/zoom_5_min"); }
+void BasicUI::zoom_10_min() { access_action("Editor/zoom_10_min"); }
+void BasicUI::zoom_to_session() { access_action("Editor/zooom-to-session"); }
+
+void BasicUI::scroll_up_1_track() { access_action("Editor/scroll_up_1_track"); }
+void BasicUI::scroll_dn_1_track() { access_action("Editor/scroll_dn_1_track"); }
 
 
 bool
diff --git a/libs/surfaces/control_protocol/control_protocol/basic_ui.h b/libs/surfaces/control_protocol/control_protocol/basic_ui.h
index 9089702947..4ddf5c1716 100644
--- a/libs/surfaces/control_protocol/control_protocol/basic_ui.h
+++ b/libs/surfaces/control_protocol/control_protocol/basic_ui.h
@@ -106,6 +106,26 @@ class LIBCONTROLCP_API BasicUI {
 	void set_record_enable (bool yn);
 	bool get_record_enabled ();
 
+	//editor visibility stuff  (why do we have to make explicit numbers here?  because "gui actions" don't accept args 
+	void fit_1_track();
+	void fit_2_tracks();
+	void fit_4_tracks();
+	void fit_8_tracks();
+	void fit_16_tracks();
+	void fit_32_tracks();
+	void fit_all_tracks();
+	void zoom_10_ms();
+	void zoom_100_ms();
+	void zoom_1_sec();
+	void zoom_10_sec();
+	void zoom_1_min();
+	void zoom_5_min();
+	void zoom_10_min();
+	void zoom_to_session();
+	
+	void scroll_up_1_track();
+	void scroll_dn_1_track();
+
 	void rec_enable_toggle ();
 	void toggle_all_rec_enables ();
 
diff --git a/libs/surfaces/osc/osc.cc b/libs/surfaces/osc/osc.cc
index 85f024e597..9dd0bc5144 100644
--- a/libs/surfaces/osc/osc.cc
+++ b/libs/surfaces/osc/osc.cc
@@ -376,6 +376,19 @@ OSC::register_callbacks()
 		REGISTER_CALLBACK (serv, "/ardour/toggle_monitor_mono", "", toggle_monitor_mono);
 		REGISTER_CALLBACK (serv, "/ardour/quick_snapshot_switch", "", quick_snapshot_switch);
 		REGISTER_CALLBACK (serv, "/ardour/quick_snapshot_stay", "", quick_snapshot_stay);
+		REGISTER_CALLBACK (serv, "/ardour/fit_1_track", "", fit_1_track);
+		REGISTER_CALLBACK (serv, "/ardour/fit_2_tracks", "", fit_2_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/fit_4_tracks", "", fit_4_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/fit_8_tracks", "", fit_8_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/fit_16_tracks", "", fit_16_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/fit_32_tracks", "", fit_32_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/fit_all_tracks", "", fit_all_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/zoom_100_ms", "", zoom_100_ms);
+		REGISTER_CALLBACK (serv, "/ardour/zoom_1_sec", "", zoom_1_sec);
+		REGISTER_CALLBACK (serv, "/ardour/zoom_1_min", "", zoom_1_min);
+		REGISTER_CALLBACK (serv, "/ardour/zoom_5_min", "", zoom_5_min);
+		REGISTER_CALLBACK (serv, "/ardour/zoom_10_min", "", zoom_10_min);
+		REGISTER_CALLBACK (serv, "/ardour/zoom_to_session", "", zoom_to_session);
 
 
 		/*
@@ -420,6 +433,21 @@ OSC::register_callbacks()
 		REGISTER_CALLBACK (serv, "/ardour/pushbutton/toggle_monitor_mono", "f", toggle_monitor_mono);
 		REGISTER_CALLBACK (serv, "/ardour/pushbutton/quick_snapshot_switch", "f", quick_snapshot_switch);
 		REGISTER_CALLBACK (serv, "/ardour/pushbutton/quick_snapshot_stay", "f", quick_snapshot_stay);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/fit_1_track", "f", fit_1_track);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/fit_2_tracks", "f", fit_2_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/fit_4_tracks", "f", fit_4_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/fit_8_tracks", "f", fit_8_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/fit_16_tracks", "f", fit_16_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/fit_32_tracks", "f", fit_32_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/fit_all_tracks", "f", fit_all_tracks);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/zoom_100_ms", "f", zoom_100_ms);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/zoom_1_sec", "f", zoom_1_sec);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/zoom_1_min", "f", zoom_1_min);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/zoom_5_min", "f", zoom_5_min);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/zoom_10_min", "f", zoom_10_min);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/zoom_to_session", "f", zoom_to_session);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/scroll_up_1_track", "f", scroll_up_1_track);
+		REGISTER_CALLBACK (serv, "/ardour/pushbutton/scroll_dn_1_track", "f", scroll_dn_1_track);
 
 		/* These commands require the route index in addition to the arg; TouchOSC (et al) can't use these  */ 
 		REGISTER_CALLBACK (serv, "/ardour/routes/mute", "ii", route_mute);
diff --git a/libs/surfaces/osc/osc.h b/libs/surfaces/osc/osc.h
index 947ddee6ce..6ccbbfdbb0 100644
--- a/libs/surfaces/osc/osc.h
+++ b/libs/surfaces/osc/osc.h
@@ -206,6 +206,21 @@ class OSC : public ARDOUR::ControlProtocol, public AbstractUI<OSCUIRequest>
 	PATH_CALLBACK(toggle_monitor_mono);
 	PATH_CALLBACK(quick_snapshot_stay);
 	PATH_CALLBACK(quick_snapshot_switch);
+	PATH_CALLBACK(fit_1_track);
+	PATH_CALLBACK(fit_2_tracks);
+	PATH_CALLBACK(fit_4_tracks);
+	PATH_CALLBACK(fit_8_tracks);
+	PATH_CALLBACK(fit_16_tracks);
+	PATH_CALLBACK(fit_32_tracks);
+	PATH_CALLBACK(fit_all_tracks);
+	PATH_CALLBACK(zoom_100_ms);
+	PATH_CALLBACK(zoom_1_sec);
+	PATH_CALLBACK(zoom_1_min);
+	PATH_CALLBACK(zoom_5_min);
+	PATH_CALLBACK(zoom_10_min);
+	PATH_CALLBACK(zoom_to_session);
+	PATH_CALLBACK(scroll_up_1_track);
+	PATH_CALLBACK(scroll_dn_1_track);
 
 #define PATH_CALLBACK1(name,type,optional)					\
         static int _ ## name (const char *path, const char *types, lo_arg **argv, int argc, void *data, void *user_data) { \