diff options
| author | Paul Davis <paul@linuxaudiosystems.com> | 2016-09-23 13:57:29 -0500 |
|---|---|---|
| committer | Paul Davis <paul@linuxaudiosystems.com> | 2016-09-27 14:59:32 -0500 |
| commit | 6d5878a92614304711fb77b0c863d68cb2d44d21 (patch) | |
| tree | 6904cc33574968393c019dab2bf87d6884839d33 /libs/surfaces/push2/push2.cc | |
| parent | 0aaf2d1f341f19b5cc2a4ae223a98e56a0c12341 (diff) | |
leave a comment about port reconnection
Diffstat (limited to 'libs/surfaces/push2/push2.cc')
| -rw-r--r-- | libs/surfaces/push2/push2.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/libs/surfaces/push2/push2.cc b/libs/surfaces/push2/push2.cc index a9498ee383..ec234be712 100644 --- a/libs/surfaces/push2/push2.cc +++ b/libs/surfaces/push2/push2.cc @@ -1537,6 +1537,14 @@ Push2::stripable_selection_change (StripableNotificationListPtr selected) /* disconnect from pad port, if appropriate */ if (current_midi_track && pad_port) { + + /* XXX this could possibly leave dangling MIDI notes. + * + * A general libardour fix is required. It isn't obvious + * how note resolution can be done unless disconnecting + * becomes "slow" (i.e. deferred for as long as it takes + * to resolve notes). + */ current_midi_track->input()->disconnect (current_midi_track->input()->nth(0), pad_port->name(), this); } |