fix up some issues introduced by lifecycle tracking of Controllable in Generic MIDI control code

git-svn-id: svn://localhost/ardour2/branches/3.0@12947 d708f5d6-7413-0410-9779-e7cbd77b26cf

1 files changed, 2 insertions, 3 deletions

diff --git a/libs/surfaces/generic_midi/midicontrollable.cc b/libs/surfaces/generic_midi/midicontrollable.cc
index a6d0b1c5ac..f866bab2bb 100644
--- a/libs/surfaces/generic_midi/midicontrollable.cc
+++ b/libs/surfaces/generic_midi/midicontrollable.cc
@@ -25,6 +25,7 @@
 #include "pbd/error.h"
 #include "pbd/controllable_descriptor.h"
 #include "pbd/xml++.h"
+#include "pbd/stacktrace.h"
 
 #include "midi++/port.h"
 #include "midi++/channel.h"
@@ -77,7 +78,7 @@ MIDIControllable::MIDIControllable (GenericMidiControlProtocol* s, Port& p, Cont
 
 MIDIControllable::~MIDIControllable ()
 {
-	drop_controllable ();
+	drop_external_control ();
 }
 
 int
@@ -112,7 +113,6 @@ MIDIControllable::drop_external_control ()
 void
 MIDIControllable::set_controllable (Controllable* c)
 {
-	drop_controllable ();
 	controllable = c;
 }
 
@@ -210,7 +210,6 @@ MIDIControllable::lookup_controllable()
 void
 MIDIControllable::drop_controllable ()
 {
-	drop_external_control ();
 	controllable_death_connection.disconnect ();
 	controllable = 0;
 }