*** NEW CODING POLICY ***

All #include statements that include a header that is a part of a library
bundled with ardour MUST use quotes, not angle brackets.

Do this:

#include "ardour/types.h"

NOT this:

#include <ardour/types.h>

Rationale:

This is best practice in general, to ensure we include the local version
and not the system version.  That quotes mean "local" (in some sense)
and angle brackets mean "system" (in some sense) is a ubiquitous
convention and IIRC right in the C spec somewhere.

More pragmatically, this is required by (my) waf (stuff) for dependencies
to work correctly.  That is:

!!! FAILURE TO DO THIS CAN RESULT IN BROKEN BUILDS !!!

Failure to comply is punishable by death by torture. :)

P.S. It's not that dramatic in all cases, but this (in combination with some
GCC flags specific to the include type) is the best way I have found to be
absolutely 100% positive the local ones are being used (and we definitely
want to be absolutely 100% positive on that one).


git-svn-id: svn://localhost/ardour2/branches/3.0@4655 d708f5d6-7413-0410-9779-e7cbd77b26cf

44 files changed, 80 insertions, 80 deletions

diff --git a/libs/pbd/base_ui.cc b/libs/pbd/base_ui.cc
index 0dbe6baf52..015951f118 100644
--- a/libs/pbd/base_ui.cc
+++ b/libs/pbd/base_ui.cc
@@ -24,10 +24,10 @@
 #include <cerrno>
 #include <cstring>
 
-#include <pbd/base_ui.h>
-#include <pbd/error.h>
-#include <pbd/compose.h>
-#include <pbd/failed_constructor.h>
+#include "pbd/base_ui.h"
+#include "pbd/error.h"
+#include "pbd/compose.h"
+#include "pbd/failed_constructor.h"
 
 #include "i18n.h"
 
diff --git a/libs/pbd/basename.cc b/libs/pbd/basename.cc
index 0b631f4249..2d132408c7 100644
--- a/libs/pbd/basename.cc
+++ b/libs/pbd/basename.cc
@@ -17,7 +17,7 @@
 
 */
 
-#include <pbd/basename.h>
+#include "pbd/basename.h"
 #include <glibmm/miscutils.h>
 
 using Glib::ustring;
diff --git a/libs/pbd/command.cc b/libs/pbd/command.cc
index 2b64c46030..452223317b 100644
--- a/libs/pbd/command.cc
+++ b/libs/pbd/command.cc
@@ -17,8 +17,8 @@
 
 */
 
-#include <pbd/command.h>
-#include <pbd/xml++.h>
+#include "pbd/command.h"
+#include "pbd/xml++.h"
 
 XMLNode &Command::get_state()
 {
diff --git a/libs/pbd/controllable.cc b/libs/pbd/controllable.cc
index 4788965c97..ba6b32282b 100644
--- a/libs/pbd/controllable.cc
+++ b/libs/pbd/controllable.cc
@@ -17,9 +17,9 @@
 
 */
 
-#include <pbd/controllable.h>
-#include <pbd/xml++.h>
-#include <pbd/error.h>
+#include "pbd/controllable.h"
+#include "pbd/xml++.h"
+#include "pbd/error.h"
 
 #include "i18n.h"
 
diff --git a/libs/pbd/enumwriter.cc b/libs/pbd/enumwriter.cc
index 7033e5f3b1..134a00a207 100644
--- a/libs/pbd/enumwriter.cc
+++ b/libs/pbd/enumwriter.cc
@@ -23,9 +23,9 @@
 #include <cstring>
 #include <cstdlib>
 
-#include <pbd/enumwriter.h>
-#include <pbd/error.h>
-#include <pbd/compose.h>
+#include "pbd/enumwriter.h"
+#include "pbd/error.h"
+#include "pbd/compose.h"
 
 using namespace std;
 using namespace PBD;
diff --git a/libs/pbd/error.cc b/libs/pbd/error.cc
index f3568d0877..f428c16c5b 100644
--- a/libs/pbd/error.cc
+++ b/libs/pbd/error.cc
@@ -17,7 +17,7 @@
 
 */
 
-#include <pbd/error.h>
+#include "pbd/error.h"
 
 Transmitter  PBD::error (Transmitter::Error);
 Transmitter  PBD::info (Transmitter::Info);
diff --git a/libs/pbd/file_utils.cc b/libs/pbd/file_utils.cc
index 6af039a83e..1e9ff03c6f 100644
--- a/libs/pbd/file_utils.cc
+++ b/libs/pbd/file_utils.cc
@@ -22,10 +22,10 @@
 #include <glibmm/fileutils.h>
 #include <glibmm/pattern.h>
 
-#include <pbd/compose.h>
-#include <pbd/file_utils.h>
+#include "pbd/compose.h"
+#include "pbd/file_utils.h"
 
-#include <pbd/error.h>
+#include "pbd/error.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/filesystem.cc b/libs/pbd/filesystem.cc
index 84d18cfcd2..4d82ed2fe6 100644
--- a/libs/pbd/filesystem.cc
+++ b/libs/pbd/filesystem.cc
@@ -27,9 +27,9 @@
 #include <glibmm/fileutils.h>
 #include <glibmm/miscutils.h>
 
-#include <pbd/filesystem.h>
-#include <pbd/error.h>
-#include <pbd/compose.h>
+#include "pbd/filesystem.h"
+#include "pbd/error.h"
+#include "pbd/compose.h"
 
 #include "i18n.h"
 
diff --git a/libs/pbd/filesystem_paths.cc b/libs/pbd/filesystem_paths.cc
index 6846cb5aa5..a5c3c65c16 100644
--- a/libs/pbd/filesystem_paths.cc
+++ b/libs/pbd/filesystem_paths.cc
@@ -18,7 +18,7 @@
 
 #include <glib.h>
 
-#include <pbd/filesystem_paths.h>
+#include "pbd/filesystem_paths.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/fpu.cc b/libs/pbd/fpu.cc
index 76150824c7..5f9d4c2778 100644
--- a/libs/pbd/fpu.cc
+++ b/libs/pbd/fpu.cc
@@ -2,8 +2,8 @@
 #include <cstdlib>
 #include <stdint.h>
 
-#include <pbd/fpu.h>
-#include <pbd/error.h>
+#include "pbd/fpu.h"
+#include "pbd/error.h"
 
 #include "i18n.h"
 
diff --git a/libs/pbd/i18n.h b/libs/pbd/i18n.h
index 7c79d2eb53..af1ac9d162 100644
--- a/libs/pbd/i18n.h
+++ b/libs/pbd/i18n.h
@@ -1,7 +1,7 @@
 #ifndef __i18n_h__
 #define __i18n_h__
 
-#include <pbd/compose.h>
+#include "pbd/compose.h"
 #include "gettext.h"
 
 #define _(Text) dgettext (PACKAGE, Text)
diff --git a/libs/pbd/id.cc b/libs/pbd/id.cc
index 642243a36a..d24d22a0f9 100644
--- a/libs/pbd/id.cc
+++ b/libs/pbd/id.cc
@@ -26,7 +26,7 @@
 #endif
 #include <inttypes.h>
 
-#include <pbd/id.h>
+#include "pbd/id.h"
 #include <string>
 
 using namespace std;
diff --git a/libs/pbd/mountpoint.cc b/libs/pbd/mountpoint.cc
index a4063a0e40..e85a299e0b 100644
--- a/libs/pbd/mountpoint.cc
+++ b/libs/pbd/mountpoint.cc
@@ -24,7 +24,7 @@
 #include <cstring>
 #include <limits.h>
 
-#include <pbd/mountpoint.h>
+#include "pbd/mountpoint.h"
 
 using std::string;
 
diff --git a/libs/pbd/pathscanner.cc b/libs/pbd/pathscanner.cc
index e12df5efac..a9847ad250 100644
--- a/libs/pbd/pathscanner.cc
+++ b/libs/pbd/pathscanner.cc
@@ -25,9 +25,9 @@
 #include <vector>
 #include <dirent.h>
 
-#include <pbd/error.h>
-#include <pbd/pathscanner.h>
-#include <pbd/stl_delete.h>
+#include "pbd/error.h"
+#include "pbd/pathscanner.h"
+#include "pbd/stl_delete.h"
 
 using namespace PBD;
 
diff --git a/libs/pbd/pbd/abstract_ui.cc b/libs/pbd/pbd/abstract_ui.cc
index 8e5b9ceb07..a4c92c0de9 100644
--- a/libs/pbd/pbd/abstract_ui.cc
+++ b/libs/pbd/pbd/abstract_ui.cc
@@ -1,8 +1,8 @@
 #include <unistd.h>
 
-#include <pbd/abstract_ui.h>
-#include <pbd/pthread_utils.h>
-#include <pbd/failed_constructor.h>
+#include "pbd/abstract_ui.h"
+#include "pbd/pthread_utils.h"
+#include "pbd/failed_constructor.h"
 
 #include "i18n.h"
 
diff --git a/libs/pbd/pbd/abstract_ui.h b/libs/pbd/pbd/abstract_ui.h
index 88c27aa0bc..adb9aabf0e 100644
--- a/libs/pbd/pbd/abstract_ui.h
+++ b/libs/pbd/pbd/abstract_ui.h
@@ -28,9 +28,9 @@
 
 #include <glibmm/thread.h>
 
-#include <pbd/receiver.h>
-#include <pbd/ringbufferNPT.h>
-#include <pbd/base_ui.h>
+#include "pbd/receiver.h"
+#include "pbd/ringbufferNPT.h"
+#include "pbd/base_ui.h"
 
 class Touchable;
 
diff --git a/libs/pbd/pbd/command.h b/libs/pbd/pbd/command.h
index 1521a60350..240118901c 100644
--- a/libs/pbd/pbd/command.h
+++ b/libs/pbd/pbd/command.h
@@ -21,7 +21,7 @@
 #ifndef __lib_pbd_command_h__
 #define __lib_pbd_command_h__
 
-#include <pbd/statefuldestructible.h>
+#include "pbd/statefuldestructible.h"
 #include <boost/utility.hpp>
 
 class Command : public PBD::StatefulDestructible, public boost::noncopyable
diff --git a/libs/pbd/pbd/controllable.h b/libs/pbd/pbd/controllable.h
index 6d37464419..0007e04fd3 100644
--- a/libs/pbd/pbd/controllable.h
+++ b/libs/pbd/pbd/controllable.h
@@ -26,7 +26,7 @@
 #include <sigc++/trackable.h>
 #include <sigc++/signal.h>
 
-#include <pbd/statefuldestructible.h>
+#include "pbd/statefuldestructible.h"
 
 class XMLNode;
 
diff --git a/libs/pbd/pbd/crossthread.h b/libs/pbd/pbd/crossthread.h
index b815cfd319..c63c863f38 100644
--- a/libs/pbd/pbd/crossthread.h
+++ b/libs/pbd/pbd/crossthread.h
@@ -20,7 +20,7 @@
 #ifndef __pbd__crossthread_h__
 #define __pbd__crossthread_h__
 
-#include <pbd/abstract_ui.h>
+#include "pbd/abstract_ui.h"
 #include <sigc++/sigc++.h>
 #include <pthread.h>
 
diff --git a/libs/pbd/pbd/file_utils.h b/libs/pbd/pbd/file_utils.h
index a9832ce720..ce5422db13 100644
--- a/libs/pbd/pbd/file_utils.h
+++ b/libs/pbd/pbd/file_utils.h
@@ -25,7 +25,7 @@
 
 #include <glibmm/pattern.h>
 
-#include <pbd/search_path.h>
+#include "pbd/search_path.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/filesystem_paths.h b/libs/pbd/pbd/filesystem_paths.h
index 4e09c6ec4b..8b767a3dfc 100644
--- a/libs/pbd/pbd/filesystem_paths.h
+++ b/libs/pbd/pbd/filesystem_paths.h
@@ -21,7 +21,7 @@
 
 #include <vector>
 
-#include <pbd/filesystem.h>
+#include "pbd/filesystem.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/functor_command.h b/libs/pbd/pbd/functor_command.h
index e6c07cfdbe..b651c6f775 100644
--- a/libs/pbd/pbd/functor_command.h
+++ b/libs/pbd/pbd/functor_command.h
@@ -25,10 +25,10 @@
 #include <string>
 #include <map>
 
-#include <pbd/xml++.h>
-#include <pbd/shiva.h>
-#include <pbd/command.h>
-#include <pbd/failed_constructor.h>
+#include "pbd/xml++.h"
+#include "pbd/shiva.h"
+#include "pbd/command.h"
+#include "pbd/failed_constructor.h"
 
 /** This command class is initialized 
  */
diff --git a/libs/pbd/pbd/memento_command.h b/libs/pbd/pbd/memento_command.h
index 1a6600b1b5..e89da70c20 100644
--- a/libs/pbd/pbd/memento_command.h
+++ b/libs/pbd/pbd/memento_command.h
@@ -23,10 +23,10 @@
 
 #include <iostream>
 
-#include <pbd/command.h>
-#include <pbd/stacktrace.h>
-#include <pbd/xml++.h>
-#include <pbd/shiva.h>
+#include "pbd/command.h"
+#include "pbd/stacktrace.h"
+#include "pbd/xml++.h"
+#include "pbd/shiva.h"
 
 #include <sigc++/slot.h>
 #include <typeinfo>
diff --git a/libs/pbd/pbd/pool.h b/libs/pbd/pbd/pool.h
index d604680ae2..66a87abf96 100644
--- a/libs/pbd/pbd/pool.h
+++ b/libs/pbd/pbd/pool.h
@@ -25,7 +25,7 @@
 
 #include <glibmm/thread.h>
 
-#include <pbd/ringbuffer.h>
+#include "pbd/ringbuffer.h"
 
 class Pool 
 {
diff --git a/libs/pbd/pbd/search_path.h b/libs/pbd/pbd/search_path.h
index 505583b3e0..6163aae607 100644
--- a/libs/pbd/pbd/search_path.h
+++ b/libs/pbd/pbd/search_path.h
@@ -23,7 +23,7 @@
 #include <string>
 #include <vector>
 
-#include <pbd/filesystem.h>
+#include "pbd/filesystem.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/stateful.h b/libs/pbd/pbd/stateful.h
index 8ea647475a..0d75a8579a 100644
--- a/libs/pbd/pbd/stateful.h
+++ b/libs/pbd/pbd/stateful.h
@@ -21,7 +21,7 @@
 #define __pbd_stateful_h__
 
 #include <string>
-#include <pbd/id.h>
+#include "pbd/id.h"
 
 class XMLNode;
 
diff --git a/libs/pbd/pbd/statefuldestructible.h b/libs/pbd/pbd/statefuldestructible.h
index 83eff473d6..49a33ff438 100644
--- a/libs/pbd/pbd/statefuldestructible.h
+++ b/libs/pbd/pbd/statefuldestructible.h
@@ -20,8 +20,8 @@
 #ifndef __pbd_stateful_destructible_h__
 #define __pbd_stateful_destructible_h__
 
-#include <pbd/stateful.h>
-#include <pbd/destructible.h>
+#include "pbd/stateful.h"
+#include "pbd/destructible.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/tokenizer.h b/libs/pbd/pbd/tokenizer.h
index 9206d1b6fb..39954194fb 100644
--- a/libs/pbd/pbd/tokenizer.h
+++ b/libs/pbd/pbd/tokenizer.h
@@ -23,7 +23,7 @@
 #include <iterator>
 #include <string>
 
-#include <pbd/whitespace.h>
+#include "pbd/whitespace.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/undo.h b/libs/pbd/pbd/undo.h
index cf1f6f3470..0e48bea962 100644
--- a/libs/pbd/pbd/undo.h
+++ b/libs/pbd/pbd/undo.h
@@ -26,8 +26,8 @@
 #include <sigc++/slot.h>
 #include <sigc++/bind.h>
 #include <sys/time.h>
-#include <pbd/command.h>
-#include <pbd/shiva.h>
+#include "pbd/command.h"
+#include "pbd/shiva.h"
 
 typedef sigc::slot<void> UndoAction;
 
diff --git a/libs/pbd/pool.cc b/libs/pbd/pool.cc
index 6d41f14f7e..2a9022542a 100644
--- a/libs/pbd/pool.cc
+++ b/libs/pbd/pool.cc
@@ -23,8 +23,8 @@
 #include <vector>
 #include <cstdlib>
 
-#include <pbd/pool.h>
-#include <pbd/error.h>
+#include "pbd/pool.h"
+#include "pbd/error.h"
 
 using namespace std;
 using namespace PBD;
diff --git a/libs/pbd/pthread_utils.cc b/libs/pbd/pthread_utils.cc
index c63f988af3..8274223487 100644
--- a/libs/pbd/pthread_utils.cc
+++ b/libs/pbd/pthread_utils.cc
@@ -23,7 +23,7 @@
 #include <string>
 #include <stdint.h>
 
-#include <pbd/pthread_utils.h>
+#include "pbd/pthread_utils.h"
 
 using namespace std;
 
diff --git a/libs/pbd/receiver.cc b/libs/pbd/receiver.cc
index 5e7c10de70..456ff3ae79 100644
--- a/libs/pbd/receiver.cc
+++ b/libs/pbd/receiver.cc
@@ -20,8 +20,8 @@
 
 #include <vector>
 
-#include <pbd/receiver.h>
-#include <pbd/transmitter.h>
+#include "pbd/receiver.h"
+#include "pbd/transmitter.h"
 
 using namespace sigc;
 
diff --git a/libs/pbd/search_path.cc b/libs/pbd/search_path.cc
index 350eea05d3..2238b233fe 100644
--- a/libs/pbd/search_path.cc
+++ b/libs/pbd/search_path.cc
@@ -17,9 +17,9 @@
 
 */
 
-#include <pbd/tokenizer.h>
-#include <pbd/search_path.h>
-#include <pbd/error.h>
+#include "pbd/tokenizer.h"
+#include "pbd/search_path.h"
+#include "pbd/error.h"
 
 namespace {
 
diff --git a/libs/pbd/shortpath.cc b/libs/pbd/shortpath.cc
index 9f9598e617..d283631cde 100644
--- a/libs/pbd/shortpath.cc
+++ b/libs/pbd/shortpath.cc
@@ -17,7 +17,7 @@
 
 */
 
-#include <pbd/shortpath.h>
+#include "pbd/shortpath.h"
 
 using namespace Glib;
 using namespace std;
diff --git a/libs/pbd/stacktrace.cc b/libs/pbd/stacktrace.cc
index c517967fa2..d2e765997a 100644
--- a/libs/pbd/stacktrace.cc
+++ b/libs/pbd/stacktrace.cc
@@ -17,7 +17,7 @@
 
 */
 
-#include <pbd/stacktrace.h>
+#include "pbd/stacktrace.h"
 #include <iostream>
 
 void
diff --git a/libs/pbd/stateful.cc b/libs/pbd/stateful.cc
index 4adcab478c..8846226ad3 100644
--- a/libs/pbd/stateful.cc
+++ b/libs/pbd/stateful.cc
@@ -20,10 +20,10 @@
 
 #include <unistd.h>
 
-#include <pbd/stateful.h>
-#include <pbd/filesystem.h>
-#include <pbd/xml++.h>
-#include <pbd/error.h>
+#include "pbd/stateful.h"
+#include "pbd/filesystem.h"
+#include "pbd/xml++.h"
+#include "pbd/error.h"
 
 #include "i18n.h"
 
diff --git a/libs/pbd/strreplace.cc b/libs/pbd/strreplace.cc
index 7999b5c6c9..5d36608b3b 100644
--- a/libs/pbd/strreplace.cc
+++ b/libs/pbd/strreplace.cc
@@ -17,7 +17,7 @@
 
 */
 
-#include <pbd/replace_all.h>
+#include "pbd/replace_all.h"
 
 int
 replace_all (std::string& str,
diff --git a/libs/pbd/strsplit.cc b/libs/pbd/strsplit.cc
index 342daadaa2..d30b7356ac 100644
--- a/libs/pbd/strsplit.cc
+++ b/libs/pbd/strsplit.cc
@@ -17,7 +17,7 @@
 
 */
 
-#include <pbd/strsplit.h>
+#include "pbd/strsplit.h"
 
 using namespace std;
 using namespace Glib;
diff --git a/libs/pbd/textreceiver.cc b/libs/pbd/textreceiver.cc
index 43620e9830..2cd1cf3712 100644
--- a/libs/pbd/textreceiver.cc
+++ b/libs/pbd/textreceiver.cc
@@ -21,7 +21,7 @@
 #include <iostream>
 #include <cstdlib>
 
-#include <pbd/textreceiver.h>
+#include "pbd/textreceiver.h"
 
 TextReceiver::TextReceiver (const string &n)
 
diff --git a/libs/pbd/transmitter.cc b/libs/pbd/transmitter.cc
index 876a9d86e5..9a2dda86c4 100644
--- a/libs/pbd/transmitter.cc
+++ b/libs/pbd/transmitter.cc
@@ -23,8 +23,8 @@
 #include <iostream>
 #include <string>
 
-#include <pbd/transmitter.h>
-#include <pbd/error.h>
+#include "pbd/transmitter.h"
+#include "pbd/error.h"
 
 using std::string;
 using std::ios;
diff --git a/libs/pbd/undo.cc b/libs/pbd/undo.cc
index 5365a98146..a0e98f9a13 100644
--- a/libs/pbd/undo.cc
+++ b/libs/pbd/undo.cc
@@ -22,8 +22,8 @@
 #include <sstream>
 #include <time.h>
 
-#include <pbd/undo.h>
-#include <pbd/xml++.h>
+#include "pbd/undo.h"
+#include "pbd/xml++.h"
 
 #include <sigc++/bind.h>
 
diff --git a/libs/pbd/uuid.cc b/libs/pbd/uuid.cc
index 0ccffa2091..0ffeca23cb 100644
--- a/libs/pbd/uuid.cc
+++ b/libs/pbd/uuid.cc
@@ -18,7 +18,7 @@
 
 */
 
-#include <pbd/uuid.h>
+#include "pbd/uuid.h"
 
 using namespace PBD;
 
diff --git a/libs/pbd/whitespace.cc b/libs/pbd/whitespace.cc
index b09d830103..d73fced321 100644
--- a/libs/pbd/whitespace.cc
+++ b/libs/pbd/whitespace.cc
@@ -17,7 +17,7 @@
 
 */
 
-#include <pbd/whitespace.h>
+#include "pbd/whitespace.h"
 
 using namespace std;
 
diff --git a/libs/pbd/xml++.cc b/libs/pbd/xml++.cc
index d878245242..9f7ef6007f 100644
--- a/libs/pbd/xml++.cc
+++ b/libs/pbd/xml++.cc
@@ -5,7 +5,7 @@
  * Modified for Ardour and released under the same terms.
  */
 
-#include <pbd/xml++.h>
+#include "pbd/xml++.h"
 #include <libxml/debugXML.h>
 #include <libxml/xpath.h>
 #include <libxml/xpathInternals.h>