diff options
| author | Tim Mayberry <mojofunk@gmail.com> | 2016-09-23 22:56:36 +1000 |
|---|---|---|
| committer | Tim Mayberry <mojofunk@gmail.com> | 2016-10-10 08:45:34 +1000 |
| commit | e84fbfe6e5a48915e2e3b01b7867e0f3ff2a64ce (patch) | |
| tree | 9560b3997d59cf8aba56e22261e25f9596ff55f1 /libs/pbd/pbd | |
| parent | 97752e6a5117c77de93a1b3ce5959eb3181156f5 (diff) | |
Remove PropertyMap from XMLNode class
It appears that there is no performance benefit from storing properties in a
map for faster lookup or it is counteracted by the penalty of storing and
maintaining the additional data structure.
Timing results before changes with an optimized build:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 41293 Max: 63746 Total: 564448 Avg: 56444 (56 msecs)
Write : Count: 10 Min: 42932 Max: 49221 Total: 453955 Avg: 45395 (45 msecs)
Read : Count: 10 Min: 80160 Max: 84678 Total: 824506 Avg: 82450 (82 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 228759 Max: 420236 Total: 3587597 Avg: 358759 (358 msecs)
Write : Count: 10 Min: 307095 Max: 348767 Total: 3205704 Avg: 320570 (320 msecs)
Read : Count: 10 Min: 572400 Max: 657219 Total: 5959630 Avg: 595963 (595 msecs)
Perf results after changes:
XMLTest::testPerfMediumXMLDocumentTiming
Create : Count: 10 Min: 30610 Max: 42656 Total: 376672 Avg: 37667 (37 msecs)
Write : Count: 10 Min: 42804 Max: 54277 Total: 460455 Avg: 46045 (46 msecs)
Read : Count: 10 Min: 70364 Max: 85484 Total: 750909 Avg: 75090 (75 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
Create : Count: 10 Min: 164360 Max: 356995 Total: 3064482 Avg: 306448 (306 msecs)
Write : Count: 10 Min: 308655 Max: 372953 Total: 3226707 Avg: 322670 (322 msecs)
Read : Count: 10 Min: 517243 Max: 541839 Total: 5289950 Avg: 528995 (528 msecs)
Diffstat (limited to 'libs/pbd/pbd')
| -rw-r--r-- | libs/pbd/pbd/xml++.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/libs/pbd/pbd/xml++.h b/libs/pbd/pbd/xml++.h index fa55f11c35..8e348a4483 100644 --- a/libs/pbd/pbd/xml++.h +++ b/libs/pbd/pbd/xml++.h @@ -29,7 +29,6 @@ #include <string> #include <vector> -#include <map> #include <cstdio> #include <cstdarg> @@ -50,7 +49,6 @@ typedef XMLNodeList::const_iterator XMLNodeConstIterator; typedef std::vector<XMLProperty*> XMLPropertyList; typedef XMLPropertyList::iterator XMLPropertyIterator; typedef XMLPropertyList::const_iterator XMLPropertyConstIterator; -typedef std::map<std::string, XMLProperty*> XMLPropertyMap; class LIBPBD_API XMLTree { public: @@ -149,7 +147,6 @@ private: std::string _content; XMLNodeList _children; XMLPropertyList _proplist; - XMLPropertyMap _propmap; mutable XMLNodeList _selected_children; void clear_lists (); |