diff options
| author | Robin Gareus <robin@gareus.org> | 2017-05-09 21:58:50 +0200 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2017-05-10 00:26:02 +0200 |
| commit | ac03e4a937a9a0581423fa0c9cfb6cea5dbd2275 (patch) | |
| tree | acc569a7b59d601fcd22b23fc8353e3daa40b149 /libs/ardour | |
| parent | 82fed14f41f1d480fef400384d81838d1edf3d32 (diff) | |
Bump VST param-name length limit to 128 bytes and centralize definition
The official VST spec says 8 bytes, JUCE uses 24 + 1, and there's
anecdotal evidence that some VSTs use up to 100 (which apparently works
in many hosts).
Diffstat (limited to 'libs/ardour')
| -rw-r--r-- | libs/ardour/ardour/vestige/aeffectx.h | 2 | ||||
| -rw-r--r-- | libs/ardour/vst_info_file.cc | 4 | ||||
| -rw-r--r-- | libs/ardour/vst_plugin.cc | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/libs/ardour/ardour/vestige/aeffectx.h b/libs/ardour/ardour/vestige/aeffectx.h index 25be89b09a..a9a168ed1d 100644 --- a/libs/ardour/ardour/vestige/aeffectx.h +++ b/libs/ardour/ardour/vestige/aeffectx.h @@ -204,7 +204,7 @@ struct _VstEvents enum Vestige2StringConstants { VestigeMaxNameLen = 64, - VestigeMaxLabelLen = 64, + VestigeMaxLabelLen = 128, VestigeMaxShortLabelLen = 8, VestigeMaxCategLabelLen = 24, VestigeMaxFileNameLen = 100 diff --git a/libs/ardour/vst_info_file.cc b/libs/ardour/vst_info_file.cc index 77be57e8d8..b076c42227 100644 --- a/libs/ardour/vst_info_file.cc +++ b/libs/ardour/vst_info_file.cc @@ -682,8 +682,8 @@ vstfx_parse_vst_state (VSTState* vstfx) #endif for (int i = 0; i < info->numParams; ++i) { - char name[64]; - char label[64]; + char name[VestigeMaxLabelLen]; + char label[VestigeMaxLabelLen]; /* Not all plugins give parameters labels as well as names */ diff --git a/libs/ardour/vst_plugin.cc b/libs/ardour/vst_plugin.cc index 6b1f0b3254..bf7637109d 100644 --- a/libs/ardour/vst_plugin.cc +++ b/libs/ardour/vst_plugin.cc @@ -379,7 +379,7 @@ VSTPlugin::get_parameter_descriptor (uint32_t which, ParameterDescriptor& desc) /* old style */ - char label[64]; + char label[VestigeMaxLabelLen]; /* some VST plugins expect this buffer to be zero-filled */ memset (label, 0, sizeof (label)); @@ -593,7 +593,7 @@ VSTPlugin::do_remove_preset (string name) string VSTPlugin::describe_parameter (Evoral::Parameter param) { - char name[64]; + char name[VestigeMaxLabelLen]; if (param.id() == UINT32_MAX - 1) { strcpy (name, _("Plugin Enable")); return name; |