diff options
| author | Robin Gareus <robin@gareus.org> | 2017-03-12 01:24:40 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2017-03-12 01:24:40 +0100 |
| commit | 3e923470576d2867062d2b62291064cccc4dfe0f (patch) | |
| tree | 1d15e86c385320ebb65cacbf8800e34e3b9bffec /libs/ardour/vst_plugin.cc | |
| parent | 6386ebafcdadb2d45a7cf331c5bdeb2d0e37df87 (diff) | |
Prepare for graceful case-by-case fallback of VST Bypass
VST's effSetBypass may fail even though a plugin CanDo "bypass",
and it can be case-by-case (depending on plugin-settings).
This codepath is not yet active, pending testing.
Diffstat (limited to 'libs/ardour/vst_plugin.cc')
| -rw-r--r-- | libs/ardour/vst_plugin.cc | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/libs/ardour/vst_plugin.cc b/libs/ardour/vst_plugin.cc index fe601d9505..95a661c40c 100644 --- a/libs/ardour/vst_plugin.cc +++ b/libs/ardour/vst_plugin.cc @@ -98,6 +98,9 @@ uint32_t VSTPlugin::designated_bypass_port () { if (_plugin->dispatcher (_plugin, effCanDo, 0, 0, const_cast<char*> ("bypass"), 0.0f) != 0) { +#ifdef ALLOW_VST_BYPASS_TO_FAIL // yet unused, see also plugin_insert.cc + return UINT32_MAX - 1; // emulate a port +#else /* check if plugin actually supports it, * e.g. u-he Presswerk CanDo "bypass" but calling effSetBypass is a NO-OP. * (presumably the plugin-author thinks hard-bypassing is a bad idea, @@ -110,6 +113,7 @@ VSTPlugin::designated_bypass_port () } else { cerr << "Do *not* Emulate VST Bypass Port for " << name() << endl; // XXX DEBUG } +#endif } return UINT32_MAX; } @@ -163,6 +167,9 @@ VSTPlugin::set_parameter (uint32_t which, float newval) _eff_bypassed = (value == 1); } else { cerr << "effSetBypass failed rv=" << rv << endl; // XXX DEBUG +#ifdef ALLOW_VST_BYPASS_TO_FAIL // yet unused, see also vst_plugin.cc + // emit signal.. hard un/bypass from here?! +#endif } return; } |