summaryrefslogtreecommitdiff
path: root/libs/ardour/session.cc
diff options
context:
space:
mode:
authorRobin Gareus <robin@gareus.org>2017-08-01 23:27:34 +0200
committerRobin Gareus <robin@gareus.org>2017-08-01 23:27:34 +0200
commit1a288ddd952752e9fdf528eb5d135f0af7dd6f73 (patch)
tree0a6d7c37c703f3c10a85cb1486b5dcd1b853dcaa /libs/ardour/session.cc
parent9694986a85da8e7d18e9003e3706939bf4e34097 (diff)
Fix some more crashes at session-close
PortDrop unregisters backend ports, the backend will return a NULL buffer-pointer, but the I/O object still exists (Metronome, LTC) AudioBuffer::_data == 0 #0 msvcrt!memset () from C:\Windows\System32\msvcrt.dll #1 ARDOUR::AudioBuffer::silence (this=0x2c410710, len=256, offset=0) at ../libs/ardour/audio_buffer.cc:88 #2 ARDOUR::AudioPort::cycle_end (this=0x34918730, nframes=256) at ../libs/ardour/audio_port.cc:66 #3 ARDOUR::PortManager::cycle_end (this=this@entry=0x23342770, nframes=nframes@entry=256) [process callback w/o session]
Diffstat (limited to 'libs/ardour/session.cc')
-rw-r--r--libs/ardour/session.cc8
1 files changed, 7 insertions, 1 deletions
diff --git a/libs/ardour/session.cc b/libs/ardour/session.cc
index 2b4fe2b7f1..62514f6d36 100644
--- a/libs/ardour/session.cc
+++ b/libs/ardour/session.cc
@@ -644,6 +644,11 @@ Session::destroy ()
_slave = 0;
}
+ /* remove I/O objects before unsetting the engine session */
+ _click_io.reset ();
+ _ltc_input.reset ();
+ _ltc_output.reset ();
+
/* disconnect from any and all signals that we are connected to */
Port::PortSignalDrop (); /* EMIT SIGNAL */
@@ -7071,13 +7076,14 @@ Session::operation_in_progress (GQuark op) const
boost::shared_ptr<Port>
Session::ltc_input_port () const
{
+ assert (_ltc_input);
return _ltc_input->nth (0);
}
boost::shared_ptr<Port>
Session::ltc_output_port () const
{
- return _ltc_output->nth (0);
+ return _ltc_output ? _ltc_output->nth (0) : boost::shared_ptr<Port> ();
}
void