summaryrefslogtreecommitdiff
path: root/libs/ardour/audioengine.cc
diff options
context:
space:
mode:
authorTim Mayberry <mojofunk@gmail.com>2015-10-28 12:58:55 +1000
committerTim Mayberry <mojofunk@gmail.com>2016-01-14 20:41:44 +1000
commit084af96bf441c065841af6a399d4c0d3c99962d4 (patch)
tree9fbb60b5c005b730c88b2e0d468713d173f70af4 /libs/ardour/audioengine.cc
parentb93a9e26013e8143ff63fcfde1f7c714fff55be3 (diff)
Change handling of Midi note selection to eliminate signal emission/delays.
Each MidiRegionView(MRV) is connected to the Selection::ClearMidiNoteSelection signal that is used to notify the all MRV instances to clear their note selection. The MRV class also has a private static SelectionCleared signal that is used to signal other MRV instances when their selection has been cleared. When the Selection::ClearMidiNoteSelection signal is emitted it causes each MRV to also emit the SelectionCleared signal. So the emission takes quadratic time. With 1500 MRV instances emission takes about 2.2 seconds on my machine, and some operations like track selection cause it to be emitted 3 times(another issue). The Selection class in the Editor knows which MRV instances have note selections, as it is notified by MidiRegionView whenever the selection count becomes zero or becomes non-zero. Clearing the Note selection should then just be O(N) and direct calls can be used rather than signals. This change removes both the signals and uses the existing references between Selection and MRV class to control note selection. There should be no behavioural changes in Midi note selection with this change.
Diffstat (limited to 'libs/ardour/audioengine.cc')
0 files changed, 0 insertions, 0 deletions