diff options
| author | Paul Davis <paul@linuxaudiosystems.com> | 2011-01-04 14:29:46 +0000 |
|---|---|---|
| committer | Paul Davis <paul@linuxaudiosystems.com> | 2011-01-04 14:29:46 +0000 |
| commit | f4b2805533e4553e86600d6fb1a31567adc1c5bd (patch) | |
| tree | 868b032e14a83561c40787511adcf30669232777 /libs/ardour/ardour | |
| parent | dc8b69af2003b3152471925594b557ab00886df2 (diff) | |
fix a bug that defined two configuration variables as "char" and thus serialized them as XML incorrectly
git-svn-id: svn://localhost/ardour2/branches/3.0@8432 d708f5d6-7413-0410-9779-e7cbd77b26cf
Diffstat (limited to 'libs/ardour/ardour')
| -rw-r--r-- | libs/ardour/ardour/rc_configuration_vars.h | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/libs/ardour/ardour/rc_configuration_vars.h b/libs/ardour/ardour/rc_configuration_vars.h index 1eaa640e60..198d604efa 100644 --- a/libs/ardour/ardour/rc_configuration_vars.h +++ b/libs/ardour/ardour/rc_configuration_vars.h @@ -17,6 +17,14 @@ */ +/***************************************************** + DO NOT USE uint8_t or any other type that resolves + to a single char, because the value will be + stored incorrectly when serialized. Use int32_t + instead and ensure that code correctly limits + the value of the variable. +*****************************************************/ + /* IO connection */ CONFIG_VARIABLE (bool, auto_connect_standard_busses, "auto-connect-standard-busses", true) @@ -32,8 +40,8 @@ CONFIG_VARIABLE (bool, send_mmc, "send-mmc", true) CONFIG_VARIABLE (bool, send_midi_clock, "send-midi-clock", false) CONFIG_VARIABLE (bool, mmc_control, "mmc-control", true) CONFIG_VARIABLE (bool, midi_feedback, "midi-feedback", false) -CONFIG_VARIABLE (uint8_t, mmc_receive_device_id, "mmc-receive-device-id", 0x7f) -CONFIG_VARIABLE (uint8_t, mmc_send_device_id, "mmc-send-device-id", 0) +CONFIG_VARIABLE (int32_t, mmc_receive_device_id, "mmc-receive-device-id", 0x7f) +CONFIG_VARIABLE (int32_t, mmc_send_device_id, "mmc-send-device-id", 0) CONFIG_VARIABLE (int32_t, initial_program_change, "initial-program-change", -1) CONFIG_VARIABLE (int, mtc_qf_speed_tolerance, "mtc-qf-speed-tolerance", 5) |