diff options
| author | Paul Davis <paul@linuxaudiosystems.com> | 2014-04-13 10:29:07 -0400 |
|---|---|---|
| committer | Paul Davis <paul@linuxaudiosystems.com> | 2014-04-14 02:17:30 -0400 |
| commit | 343b06d8d3522d6b017d887ca754c91aec2430fd (patch) | |
| tree | 81aa51fa0fea6826e62480314c1ac78b112b3a9a /libs/ardour/ardour/midi_region.h | |
| parent | d2a31ab6eed8b3e8f34dbc1caf2285bb64777f55 (diff) | |
dramatic change in logic and naming for operations related to adding a MIDI region on demand and cloning/unlinking
Existing code would cause data loss due to creation of two Source objects referring the same path, one with removable flags and one without. Careful code review suggested a variety of thinkos, function naming problems and other confusion that caused this. I have tried ot extensively comment what is going on with these operations, because it is one key area in which MIDI differs from audio: with audio, capture is the only way to add a new audio region, but for MIDI there are GUI input events that can add a new region.
Diffstat (limited to 'libs/ardour/ardour/midi_region.h')
| -rw-r--r-- | libs/ardour/ardour/midi_region.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/libs/ardour/ardour/midi_region.h b/libs/ardour/ardour/midi_region.h index b326bb30d8..38229b998b 100644 --- a/libs/ardour/ardour/midi_region.h +++ b/libs/ardour/ardour/midi_region.h @@ -64,6 +64,7 @@ class LIBARDOUR_API MidiRegion : public Region ~MidiRegion(); boost::shared_ptr<MidiRegion> clone (std::string path = std::string()) const; + boost::shared_ptr<MidiRegion> clone (boost::shared_ptr<MidiSource>) const; boost::shared_ptr<MidiSource> midi_source (uint32_t n=0) const; |