summaryrefslogtreecommitdiff
path: root/gtk2_ardour
diff options
context:
space:
mode:
authorRobin Gareus <robin@gareus.org>2017-04-20 19:03:52 +0200
committerRobin Gareus <robin@gareus.org>2017-04-20 19:03:52 +0200
commit39c2b544f034f7289a8efdeed6817dd2ef8a5bea (patch)
tree1ac04d62760171daa7628218b34a52fdbf6c4b43 /gtk2_ardour
parentb6c222555f33fdab72a0d823d77faa24246a83d6 (diff)
Keep Dialogs which report process around.
Since 5.8-245-g3e43585fa, a response hides the dialog Window in ArdourDialog::on_response (to prevent dialogs windows staying around unresponsively while Ardour does background work). This logic does not apply to Dialog Windows which implement ProgressReporter or support dialog responses other than OK, Close.
Diffstat (limited to 'gtk2_ardour')
-rw-r--r--gtk2_ardour/export_dialog.h4
-rw-r--r--gtk2_ardour/export_report.h4
-rw-r--r--gtk2_ardour/export_video_dialog.h4
-rw-r--r--gtk2_ardour/normalize_dialog.h4
-rw-r--r--gtk2_ardour/session_archive_dialog.h4
-rw-r--r--gtk2_ardour/strip_silence_dialog.h4
-rw-r--r--gtk2_ardour/time_fx_dialog.h4
-rw-r--r--gtk2_ardour/transcode_video_dialog.h4
8 files changed, 32 insertions, 0 deletions
diff --git a/gtk2_ardour/export_dialog.h b/gtk2_ardour/export_dialog.h
index fee7013577..6edb797438 100644
--- a/gtk2_ardour/export_dialog.h
+++ b/gtk2_ardour/export_dialog.h
@@ -64,6 +64,10 @@ class ExportDialog : public ArdourDialog, public PBD::ScopedConnectionList
protected:
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
typedef boost::shared_ptr<ARDOUR::ExportHandler> HandlerPtr;
typedef boost::shared_ptr<ARDOUR::ExportProfileManager> ManagerPtr;
diff --git a/gtk2_ardour/export_report.h b/gtk2_ardour/export_report.h
index 4639cafc44..af91ee2dbe 100644
--- a/gtk2_ardour/export_report.h
+++ b/gtk2_ardour/export_report.h
@@ -189,6 +189,10 @@ public:
ExportReport (const std::string & title, const ARDOUR::AnalysisResults & ar);
int run ();
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
private:
void init (const ARDOUR::AnalysisResults &, bool);
void draw_waveform (Cairo::RefPtr<Cairo::ImageSurface>& wave,
diff --git a/gtk2_ardour/export_video_dialog.h b/gtk2_ardour/export_video_dialog.h
index 93fe7fb5c2..bf3ace9f30 100644
--- a/gtk2_ardour/export_video_dialog.h
+++ b/gtk2_ardour/export_video_dialog.h
@@ -51,6 +51,10 @@ class ExportVideoDialog : public ArdourDialog , public PBD::ScopedConnectionList
XMLNode& get_state ();
void set_state (const XMLNode &);
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
private:
TimeSelection export_range;
diff --git a/gtk2_ardour/normalize_dialog.h b/gtk2_ardour/normalize_dialog.h
index 53b9e71b37..d3fb2a013b 100644
--- a/gtk2_ardour/normalize_dialog.h
+++ b/gtk2_ardour/normalize_dialog.h
@@ -37,6 +37,10 @@ public:
double target_rms () const;
int run ();
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
private:
void update_progress_gui (float);
void button_clicked (int);
diff --git a/gtk2_ardour/session_archive_dialog.h b/gtk2_ardour/session_archive_dialog.h
index a0c139b63f..de07b03fce 100644
--- a/gtk2_ardour/session_archive_dialog.h
+++ b/gtk2_ardour/session_archive_dialog.h
@@ -45,6 +45,10 @@ public:
void set_encode_option (ARDOUR::Session::ArchiveEncode);
void set_only_used_sources (bool);
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
private:
Gtk::FileChooserButton target_folder_selector;
Gtk::Entry name_entry;
diff --git a/gtk2_ardour/strip_silence_dialog.h b/gtk2_ardour/strip_silence_dialog.h
index 7445b72327..a4d444e0ed 100644
--- a/gtk2_ardour/strip_silence_dialog.h
+++ b/gtk2_ardour/strip_silence_dialog.h
@@ -49,6 +49,10 @@ public:
ARDOUR::framecnt_t minimum_length () const;
ARDOUR::framecnt_t fade_length () const;
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
private:
void create_waves ();
void canvas_allocation (Gtk::Allocation &);
diff --git a/gtk2_ardour/time_fx_dialog.h b/gtk2_ardour/time_fx_dialog.h
index 03e0ccfdcd..1825414c32 100644
--- a/gtk2_ardour/time_fx_dialog.h
+++ b/gtk2_ardour/time_fx_dialog.h
@@ -74,6 +74,10 @@ class TimeFXDialog : public ArdourDialog, public ProgressReporter
void start_updates ();
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
private:
ARDOUR::framecnt_t original_length;
Gtk::Adjustment pitch_octave_adjustment;
diff --git a/gtk2_ardour/transcode_video_dialog.h b/gtk2_ardour/transcode_video_dialog.h
index 9acd1284a5..db3aba9739 100644
--- a/gtk2_ardour/transcode_video_dialog.h
+++ b/gtk2_ardour/transcode_video_dialog.h
@@ -50,6 +50,10 @@ class TranscodeVideoDialog : public ArdourDialog , public PBD::ScopedConnectionL
VtlTranscodeOption import_option ();
bool detect_ltc () { return ltc_detect.get_active (); }
+ void on_response (int response_id) {
+ Gtk::Dialog::on_response (response_id);
+ }
+
private:
void on_show ();
void open_browse_dialog ();