diff options
| author | Robin Gareus <robin@gareus.org> | 2019-03-07 17:02:12 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2019-03-07 23:50:50 +0100 |
| commit | 7b96fa1c5e99e054f43ca3272d21ae955bfa3443 (patch) | |
| tree | 67f2e5efd9ce1890ad3a6444cb114341576d26d3 /gtk2_ardour/session_dialog.cc | |
| parent | 12a415f0772048f8a38a66a037b024223bc7bbc0 (diff) | |
Fix some Gtk::Menu memory leaks
A Gtk::manage()d widget will be deleted when its parent container
is destroyed. Top-level context menus are not inside a container and
hence need to be manually deallocated.
The solution here is to use a shared Gtk::Menu pointer that is
centrally de/re-allocated.
This works because the GUI is single-threaded and at most one
context menu is visible at a time.
Diffstat (limited to 'gtk2_ardour/session_dialog.cc')
| -rw-r--r-- | gtk2_ardour/session_dialog.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gtk2_ardour/session_dialog.cc b/gtk2_ardour/session_dialog.cc index 6959d23d66..148c9ed651 100644 --- a/gtk2_ardour/session_dialog.cc +++ b/gtk2_ardour/session_dialog.cc @@ -1062,7 +1062,7 @@ SessionDialog::recent_context_mennu (GdkEventButton *ev) Gtk::TreeModel::Path tpath = recent_session_model->get_path(iter); const bool is_child = tpath.up () && tpath.up (); - Gtk::Menu* m = manage (new Menu); + Gtk::Menu* m = ARDOUR_UI::instance()->shared_popup_menu (); MenuList& items = m->items (); items.push_back (MenuElem (s, sigc::bind (sigc::hide_return (sigc::ptr_fun (&PBD::open_folder)), s))); if (!is_child) { |