diff options
| author | Robin Gareus <robin@gareus.org> | 2017-03-24 14:36:17 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2017-03-24 14:48:46 +0100 |
| commit | 962e7a214aa8841f88e5fbf6bb12499dfddeb269 (patch) | |
| tree | e6bd8a77440a43d4669ddcbfe761873a0e6c7f60 /gtk2_ardour/panner_ui.cc | |
| parent | 55b8b44889d1d08fc6b64283670fd0953642ba64 (diff) | |
Revert "consistent use of context-menu popups"
This reverts commit b3722f7063699fafd0421d504e05a7300c70e0ec.
In some cases ardour shows context-menu on right-mouse-button
release. In this case selecting a menu-entry should happen
with the left-mouse button (or any button?!)
Using ev->button is only correct if the menu is temporary and only
visible while the button is held, button release then activates the
menu-item.
This needs further work, in some cases allowing any button (0) to work
makes sense and overall consistency needs to be improved.
Different places use different strategies for context-menus which
don't always match the button used in the event-handler.
This is a hotfix (to make TAV context menus work again with left-click)
Diffstat (limited to 'gtk2_ardour/panner_ui.cc')
| -rw-r--r-- | gtk2_ardour/panner_ui.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gtk2_ardour/panner_ui.cc b/gtk2_ardour/panner_ui.cc index 37c0970830..0818833767 100644 --- a/gtk2_ardour/panner_ui.cc +++ b/gtk2_ardour/panner_ui.cc @@ -381,7 +381,7 @@ PannerUI::pan_button_event (GdkEventButton* ev) pan_menu->set_name ("ArdourContextMenu"); } build_pan_menu (); - pan_menu->popup (ev->button, ev->time); + pan_menu->popup (1, ev->time); return true; break; default: @@ -506,7 +506,7 @@ PannerUI::pan_automation_state_button_event (GdkEventButton *ev) if (pan_astate_menu == 0) { build_astate_menu (); } - pan_astate_menu->popup (ev->button, ev->time); + pan_astate_menu->popup (1, ev->time); break; default: break; @@ -527,7 +527,7 @@ PannerUI::pan_automation_style_button_event (GdkEventButton *ev) if (pan_astyle_menu == 0) { build_astyle_menu (); } - pan_astyle_menu->popup (ev->button, ev->time); + pan_astyle_menu->popup (1, ev->time); break; default: break; |