diff options
author | Paul Davis <paul@linuxaudiosystems.com> | 2013-03-27 21:50:18 -0400 |
---|---|---|
committer | Paul Davis <paul@linuxaudiosystems.com> | 2013-03-27 21:50:18 -0400 |
commit | 4abbabdcf9c6d6d98ba261d91846577a2fa2f05e (patch) | |
tree | 5a7134ccc9508a6f1da25ef3dc6d432bdc25a04f /gtk2_ardour/midi_time_axis.h | |
parent | 78aa7a13fd5e5abac70637ce6641b7d2e73dd541 (diff) |
Squashed commit of the following:
commit fdbae82077db53add90df7448a06869dac89acc6
Author: Paul Davis <paul@linuxaudiosystems.com>
Date: Wed Mar 27 21:45:28 2013 -0400
mammoth changes in basic signal flow, total redesign of MIDI channel filtering and more.
commit 59343a8283698e02bc0f622313b29e98f449e4c8
Author: Paul Davis <paul@linuxaudiosystems.com>
Date: Wed Mar 27 01:58:53 2013 -0400
initial working version after changes to MIDI channel filtering. may affect metering input too. testing not yet finished
this commit merges many deep changes in ardour's internal architecture,
combined with a total redesign of how MIDI channel filtering works.
data in a track used to flow from JACK port buffers to diskstream's ringbuffers
and was then copied from the ringbuffers into a BufferSet for use during
Route::process_output_buffers(). The butler thread would handle the movement of
data between the ringbuffers and disk.
with this commit, data now flows from JACK port buffers into the BufferSet used
for Route processing, and is copied from the BufferSet into the diskstream's
ringbuffers (the butler thread continues to handle interactions with disk as
usual).
this change allowed a dramatic consolidation of code and simplification of most
aspects of Track/Route::roll() and Track/Route::no_roll(). in particular, see
Route::fill_buffers_with_input() which now concisely describes how we move data
from JACK port buffers into the BufferSet for all Route types (including Tracks).
this work was initially motivated by changing MIDI channel filtering so that we
can process capture and playback independently. there is now a very clean
pathway for this - see MidiTrack::roll() (NOTE: This needs implementing in the
no-roll case too - a TODO item).
the channel selector for MIDI tracks has been moved out of the track header and
is now accessible via the context menu. more work is likely here, to make it
(more) obvious to the user when filtering is going on.
Diffstat (limited to 'gtk2_ardour/midi_time_axis.h')
-rw-r--r-- | gtk2_ardour/midi_time_axis.h | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/gtk2_ardour/midi_time_axis.h b/gtk2_ardour/midi_time_axis.h index 1f179baca6..e5fccd8c2f 100644 --- a/gtk2_ardour/midi_time_axis.h +++ b/gtk2_ardour/midi_time_axis.h @@ -39,7 +39,6 @@ #include "route_time_axis.h" #include "canvas.h" #include "midi_streamview.h" -#include "midi_channel_selector.h" namespace MIDI { namespace Name { @@ -62,6 +61,7 @@ class MidiScroomer; class PianoRollHeader; class StepEntry; class StepEditor; +class MidiChannelSelectorWindow; class MidiTimeAxisView : public RouteTimeAxisView { @@ -92,12 +92,6 @@ class MidiTimeAxisView : public RouteTimeAxisView void update_range(); - sigc::signal<void, ARDOUR::ChannelMode, uint16_t>& signal_channel_mode_changed() { - return _channel_selector.mode_changed; - } - - const MidiMultipleChannelSelector& channel_selector() { return _channel_selector; } - Gtk::CheckMenuItem* automation_child_menu_item (Evoral::Parameter); StepEditor* step_editor() { return _step_editor; } @@ -141,7 +135,7 @@ class MidiTimeAxisView : public RouteTimeAxisView Gtk::RadioMenuItem* _channel_color_mode_item; Gtk::RadioMenuItem* _track_color_mode_item; Gtk::Table _midi_controls_box; - MidiMultipleChannelSelector _channel_selector; + MidiChannelSelectorWindow* _channel_selector; Gtk::ComboBoxText _midnam_model_selector; Gtk::ComboBoxText _midnam_custom_device_mode_selector; @@ -157,6 +151,8 @@ class MidiTimeAxisView : public RouteTimeAxisView void add_single_channel_controller_item (Gtk::Menu_Helpers::MenuList& ctl_items, int ctl, const std::string& name); void add_multi_channel_controller_item (Gtk::Menu_Helpers::MenuList& ctl_items, int ctl, const std::string& name); void build_controller_menu (); + void toggle_channel_selector (); + void channel_selector_hidden (); void set_channel_mode (ARDOUR::ChannelMode, uint16_t); void set_note_selection (uint8_t note); |