Patch from Lincoln to fix uncommitted reversible command during rubberband selection (#3729).

git-svn-id: svn://localhost/ardour2/branches/3.0@8563 d708f5d6-7413-0410-9779-e7cbd77b26cf

1 files changed, 3 insertions, 5 deletions

diff --git a/gtk2_ardour/editor_selection.cc b/gtk2_ardour/editor_selection.cc
index 0a7ad1958c..482a778ae7 100644
--- a/gtk2_ardour/editor_selection.cc
+++ b/gtk2_ardour/editor_selection.cc
@@ -1275,7 +1275,7 @@ Editor::invert_selection ()
  *  @param preserve_if_selected true to leave the current selection alone if we're adding to the selection and all of the selectables
  *  within the region are already selected.
  */
-bool
+void
 Editor::select_all_within (
 	framepos_t start, framepos_t end, double top, double bot, const TrackViewList& tracklist, Selection::Operation op, bool preserve_if_selected
 	)
@@ -1292,7 +1292,7 @@ Editor::select_all_within (
 	}
 
 	if (found.empty()) {
-		return false;
+		return;
 	}
 
 	if (preserve_if_selected && op != Selection::Toggle) {
@@ -1302,7 +1302,7 @@ Editor::select_all_within (
 		}
 
 		if (i == found.end()) {
-			return false;
+			return;
 		}
 	}
 
@@ -1323,8 +1323,6 @@ Editor::select_all_within (
 	}
 
 	commit_reversible_command ();
-
-	return !found.empty();
 }
 
 void