summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobin Gareus <robin@gareus.org>2014-11-29 17:31:41 +0100
committerRobin Gareus <robin@gareus.org>2014-11-29 17:31:41 +0100
commitc77f4b7a186e030f0295cae03f8e3c0662f77781 (patch)
treee87edd1571f4784f0c76a8fd1d348f15bc74f254
parent48bb90eb88202c683f3bb78f7ddf11da6114c1ab (diff)
don't move faders on click.
for one, it can mess up the value when switching to numeric-entry. It is also rather useless and not Fader-like (faders are not scrollbars). Besides, "stepvalue" is way to large and causes jumps (sometimes step-value is even negative, see "fast lookahead limiter", "release time" -> some other bug)
-rw-r--r--libs/gtkmm2ext/pixfader.cc2
1 files changed, 2 insertions, 0 deletions
diff --git a/libs/gtkmm2ext/pixfader.cc b/libs/gtkmm2ext/pixfader.cc
index f62e703d73..51a397ffbe 100644
--- a/libs/gtkmm2ext/pixfader.cc
+++ b/libs/gtkmm2ext/pixfader.cc
@@ -431,6 +431,7 @@ PixFader::on_button_release_event (GdkEventButton* ev)
_adjustment.set_value (_default_value);
} else if (ev->state & Keyboard::GainFineScaleModifier) {
_adjustment.set_value (_adjustment.get_lower());
+#if 0 // ignore clicks
} else if (ev_pos == slider_pos) {
; // click on current position, no move.
} else if ((_orien == VERT && ev_pos < slider_pos) || (_orien == HORIZ && ev_pos > slider_pos)) {
@@ -438,6 +439,7 @@ PixFader::on_button_release_event (GdkEventButton* ev)
_adjustment.set_value (_adjustment.get_value() + _adjustment.get_step_increment());
} else {
_adjustment.set_value (_adjustment.get_value() - _adjustment.get_step_increment());
+#endif
}
}
return true;